Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom headers template #2621

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Fix custom headers template #2621

merged 2 commits into from
Jan 2, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 27, 2017

What does this PR do?

  • use a pointer for Headers struct in frontend.
  • fix headers templates for AllowedHosts and HostsProxyHeaders.

Motivation

Fix a bug.

Additional Notes

Due to the current refactor on master, I will add tests in the master to avoid conflicts.

@ldez ldez requested a review from a team as a code owner December 27, 2017 01:40
@traefiker traefiker added this to the 1.5 milestone Dec 27, 2017
@ldez ldez requested a review from a team as a code owner December 27, 2017 02:54
@ldez ldez mentioned this pull request Dec 27, 2017
Merged
juliens
juliens approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bfd142b into traefik:v1.5 Jan 2, 2018
@ldez ldez deleted the fix/custom-headers branch January 2, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/middleware area/provider/docker area/provider/k8s/ingress kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker