Add status code text to webui bar chart tooltip #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This changes the tooltip design a bit, now it's just "200 OK" before it was "[color] 200 [count]" with more padding |
|
@wader I think you can use https://www.npmjs.com/package/http-status-codes to simplify the code. |
wader
force-pushed
the
webui-status-code-text
branch
from
15aa0b1
to
484a9a7
Compare
|
@ldez Ok, have switched to using http-status-codes now |
wader
force-pushed
the
webui-status-code-text
branch
from
484a9a7
to
24b30e8
Compare
|
Let me know if there is something else to fix |
So you don't have to lookup status code numbers
traefiker
force-pushed
the
webui-status-code-text
branch
from
24b30e8
to
5bde590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So you don't have to lookup status code numbers
Motivation
I keept googling them
More
Not sure how to add test for this?
Additional Notes