Use gorilla readMessage and writeMessage instead of just an io.Copy #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
area/websocket
bot/light-review
traefiker
removed
bot/light-review
|
@juliens could you explain why this change was required? (Just trying to get my head around it.) |
|
Some servers embed some messages in the body of the switching protocol response. Those messages are not in the underlying connection we used before this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug in websocket
related to: containous/oxy#48
Motivation
Fixes #2629
More
Fix a bug with packet loss in websocket underlying connection. Instead of use this connection, we read messages with gorilla and write messages with gorilla