Add all available tags to Consul Catalog Backend #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
refactor/label-consul-catalog
branch
from
ad758d9
to
b6ba247
Compare
ldez
force-pushed
the
refactor/label-consul-catalog
branch
from
b6ba247
to
43ffba3
Compare
Closed
mmatur
requested changes
Jan 3, 2018
| desc string | ||
| name string | ||
| tags []string | ||
| defaultValue int64 |
There was a problem hiding this comment.
defaultValue is not used in test cases
| desc string | ||
| name string | ||
| tags []string | ||
| defaultValue int |
There was a problem hiding this comment.
defaultValue is not used in test cases
| desc string | ||
| name string | ||
| tags []string | ||
| defaultValue bool |
There was a problem hiding this comment.
defaultValue is not used in test cases
nmengin
requested changes
Jan 3, 2018
| } | ||
| } | ||
|
|
||
| func (p *CatalogProvider) getHeathCheck(tags []string) *types.HealthCheck { |
There was a problem hiding this comment.
Do you mean getHealthCheck?
| } | ||
| } | ||
|
|
||
| func TestCatalogProviderGetHeathCheck(t *testing.T) { |
There was a problem hiding this comment.
Do you mean TestCatalogProviderGetHealthCheck?
templates/consul_catalog.tmpl
Outdated
| {{end}} | ||
|
|
||
| {{ $healthCheck := getHeathCheck $service.Attributes }} |
There was a problem hiding this comment.
Do you mean getHealthCheck?
| "getCircuitBreaker": p.getCircuitBreaker, | ||
| "getLoadBalancer": p.getLoadBalancer, | ||
| "getMaxConn": p.getMaxConn, | ||
| "getHeathCheck": p.getHeathCheck, |
There was a problem hiding this comment.
Do you mean getHealthCheck?
ldez
force-pushed
the
refactor/label-consul-catalog
branch
from
43ffba3
to
06cf85f
Compare
ldez
force-pushed
the
refactor/label-consul-catalog
branch
from
06cf85f
to
c195ea1
Compare
- add a dedicate page for Consul Catalog.
ldez
force-pushed
the
refactor/label-consul-catalog
branch
from
c195ea1
to
041007d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Homogenization of the providers [part2]: all providers must have the same options available.
More
Additional Notes
After the review I will split
consulpackage toconsulandconsulcatalogRelated to #618, #1465