Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all available configuration to KV Backend #2652

Merged
merged 11 commits into from
Jan 4, 2018
Merged

Add all available configuration to KV Backend #2652

merged 11 commits into from
Jan 4, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 3, 2018 •
edited
Loading

What does this PR do?

  • add all available configuration
    • add passTLSCert.
    • add HealthCheck port.
    • add custom Headers.
    • add error pages.
    • add rate limit.
    • add basic auth.
    • add whitelistSourceRange.
    • add frontends redirect.

Motivation

Homogenization of the providers [part2]: all providers must have the same options available.

More

  • Added/updated tests

Additional Notes

Several PRs will come after that for each provider.

Related to #618, #1465

@ldez ldez added this to the 1.6 milestone Jan 3, 2018
nmengin
nmengin approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9b37503 into traefik:master Jan 4, 2018
@ldez ldez deleted the refactor/label-kv branch January 4, 2018 19:18
This was referenced Jan 16, 2018
Closed
Closed
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/boltdb area/provider/consul area/provider/etcd area/provider/kv area/provider/zk kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker