Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Consul and Consul Catalog documentation #2654

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Split Consul and Consul Catalog documentation #2654

merged 1 commit into from
Jan 4, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 4, 2018

What does this PR do?

Split Consul and Consul Catalog documentation.

Motivation

Enhance documentation.

More

  • Added/updated documentation

@traefiker traefiker added this to the 1.5 milestone Jan 4, 2018
juliens
juliens approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

@traefiker traefiker merged commit 287fb78 into traefik:v1.5 Jan 4, 2018
@ldez ldez deleted the refactor/doc-review branch January 9, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/consul area/provider/consulcatalog kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker