Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all available labels to Mesos Backend #2687

Merged
merged 6 commits into from
Jan 18, 2018
Merged

Add all available labels to Mesos Backend #2687

merged 6 commits into from
Jan 18, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 10, 2018 •
edited
Loading

What does this PR do?

  • add all available labels
    • add Circuit Breaker label
    • add Load Balancer labels
    • add Max Conn labels
    • add Health Check labels
    • add Basic Auth label
    • add WhitelistSourceRange label
    • add PassTLSCert label
    • add Redirect labels
    • add Error Pages labels
    • add Rate Limit labels
    • add Headers labels
  • enhance template readability
  • enhance template method readability

Motivation

Homogenization of the providers [part2]: all providers must have the same options available.
Homogenization of the providers [part3]: try to have a shared template

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Fixes #618, #1465

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jan 10, 2018
@ldez ldez added this to the 1.6 milestone Jan 10, 2018
@ldez ldez force-pushed the refactor/mesos branch 3 times, most recently from 8300771 to fa468d0 Compare January 11, 2018 08:30
juliens
juliens approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the refactor/mesos branch 2 times, most recently from 5d2f0ad to 2c768a9 Compare January 15, 2018 08:32
mmatur
mmatur approved these changes Jan 15, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5140bbe into traefik:master Jan 18, 2018
@ldez ldez deleted the refactor/mesos branch January 18, 2018 18:03
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/mesos kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker