Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map writes on digest auth #2695

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jan 11, 2018

What does this PR do?

This PR fix concurrent map writes in dependency go-http-auth

Motivation

Fixes #2615

Additional Notes

There is already an open issue on go-http-auth #52 but for now we use a fork https://github.com/containous/go-http-auth.

The concurrent map writes is fixed with this PR containous/go-http-auth#1

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/auth-concurrent-map-writes branch from 789edaf to c4ea0a6 Compare January 12, 2018 18:46
@traefiker traefiker merged commit 5316b41 into traefik:v1.5 Jan 12, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Jan 12, 2018
@mmatur mmatur deleted the fix/auth-concurrent-map-writes branch March 21, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants