Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression and better error handling #2702

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Add compression and better error handling #2702

merged 1 commit into from
Jan 12, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 12, 2018

What does this PR do?

  • add compression if client send the compression header and backend valid compression
  • handle close message correctly and log only real error

Related to containous/oxy#50

More

  • tests

@juliens juliens added status/2-needs-review area/websocket kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Jan 12, 2018
@traefiker traefiker added this to the 1.5 milestone Jan 12, 2018
ldez
ldez approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b5ee5c3 into v1.5 Jan 12, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Jan 12, 2018
@ldez ldez deleted the fix/oxy-comp branch January 12, 2018 18:44
@ttjiaa ttjiaa mentioned this pull request Feb 20, 2018
Merged
@ttjiaa ttjiaa mentioned this pull request May 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/websocket kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@juliens @ldez @traefiker