Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TLSConfigurations to TLS. #2744

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Rename TLSConfigurations to TLS. #2744

merged 1 commit into from
Jan 23, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 23, 2018

What does this PR do?

Rename TLSConfigurations to TLS.

Motivation

More readable configuration.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 1.5 milestone Jan 23, 2018
@ldez ldez force-pushed the refactor/rename-tls-configuration branch from d59d928 to 162b832 Compare January 23, 2018 14:25
nmengin
nmengin approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldez
LGTM

@traefiker traefiker force-pushed the refactor/rename-tls-configuration branch from 162b832 to 9cdb1cc Compare January 23, 2018 14:46
@traefiker traefiker merged commit 00e0571 into traefik:v1.5 Jan 23, 2018
@ldez ldez deleted the refactor/rename-tls-configuration branch January 23, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme area/tls kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @mmatur @emilevauge @nmengin @traefiker