Fix support for macvlan driver in docker provider #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
added
kind/enhancement
mmatur
force-pushed
the
feature/docker-macvlan
branch
3 times, most recently
from
243d400
to
5cc271f
Compare
mmatur
force-pushed
the
feature/docker-macvlan
branch
from
5cc271f
to
a150252
Compare
mmatur
changed the title
mmatur
force-pushed
the
feature/docker-macvlan
branch
2 times, most recently
from
b7b14aa
to
a7250ac
Compare
traefiker
force-pushed
the
feature/docker-macvlan
branch
from
a7250ac
to
1fc2d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix support of macvlan driver in docker swarm mode.
Today it is impossible to support macvlan driver in swarm mode because we are not able to retrieve IP addresses of containers running on other host in the cluster
Motivation
Fixes #2412
More