Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on onHostRule, ping examples, and web deprecation #2863

Merged
merged 4 commits into from
Feb 16, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 15, 2018

What does this PR do?

Update documentation

Motivation

Better documentation


As web is deprecated, you can handle the `Path` option like this
As web is deprecated, you can handle the `Path` option like this:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say rather "as the web provider is deprecated"

#### Address

As web is deprecated, you can handle the `Address` option like this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"as the web provider is deprecated"

@@ -191,7 +190,7 @@ entryPoint = "https"
```

DNS challenge needs environment variables to be executed.
This variables have to be set on the machine/container which host Traefik.
This variables have to be set on the machine/container which host Træfik.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variables ...


With two user/pass:

- `test`:`test`
- `test2`:`test2`

Passwords are encoded in MD5: you can use htpasswd to generate those ones.
Passwords are encoded in MD5: you can use `htpasswd` to generate those ones.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to generate them

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants