Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe access to ECS API pointer values. #2983

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Safe access to ECS API pointer values. #2983

merged 1 commit into from
Mar 8, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 8, 2018

What does this PR do?

Use aws converter for pointer value.

Motivation

Be safe when use value from a pointer.

Additional Notes

Related to #2978

@traefiker traefiker added this to the 1.5 milestone Mar 8, 2018
mmatur
mmatur approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws.StringValue(LGTM)

juliens
juliens approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 862957c into traefik:v1.5 Mar 8, 2018
@ldez ldez deleted the fix/ecs-pointers branch March 9, 2018 08:56
@gozer gozer mentioned this pull request Apr 11, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 1, 2021
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/ecs kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker