Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic with wrong ACME configuration #3084

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Fix panic with wrong ACME configuration #3084

merged 1 commit into from
Mar 27, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Mar 27, 2018

What does this PR do?

Fix a panic when ACME configuration has error in its EntryPoint.

Motivation

Generate a Fatal message instead of panic.

@nmengin nmengin added this to the 1.6 milestone Mar 27, 2018
ldez
ldez approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 Nice catch ;)

@ldez ldez closed this Mar 27, 2018
@ldez ldez reopened this Mar 27, 2018
@traefiker traefiker merged commit 30e048d into traefik:v1.6 Mar 27, 2018
@mmatur mmatur mentioned this pull request Mar 27, 2018
Closed
@nmengin nmengin deleted the hotfix/acme-panic branch August 3, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @juliens @mmatur @ldez @traefiker