Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation urls on README.md #3102

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Fixed documentation urls on README.md #3102

merged 2 commits into from
Mar 30, 2018

Conversation

emir
Copy link
Contributor

@emir emir commented Mar 29, 2018

I am not following existing PR template because it's just very little update for fixing broken urls on README.

@ldez ldez modified the milestones: 1.6, 1.7 Mar 29, 2018
@geraldcroes
Copy link
Contributor

Thx for spotting this one.

Actually, we think that pointing to the documentation is the solution.

Could you please update your PR and point to URLs from the documentation, e.g.

https://docs.traefik.io/configuration/backends/docker/

instead of

docs/configuration/backends/docker.md

Thanks again for your help.

@emir
Copy link
Contributor Author

emir commented Mar 29, 2018 •
edited
Loading

Hello Gérald, I updated urls👌

@ldez ldez added this to the 1.6 milestone Mar 29, 2018
@geraldcroes
Copy link
Contributor

Thank you 😄

@emir emir requested review from a team as code owners March 30, 2018 08:47
@mmatur mmatur changed the base branch from master to v1.6 March 30, 2018 08:47
ldez
ldez approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a820585 into traefik:v1.6 Mar 30, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 7, 2021
Open
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@emir @geraldcroes @juliens @mmatur @ldez @traefiker