Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACME certificates only on ACME EntryPoint #3136

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Add ACME certificates only on ACME EntryPoint #3136

merged 1 commit into from
Apr 6, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Apr 5, 2018

What does this PR do?

This PR specifies the TLS EntryPoint which will use the ACME certificates to add these certificates only on the specified acme.entryPoint.

Motivation

Add ACME certificates to the right EntryPoint and only on its.

@traefiker traefiker added this to the 1.6 milestone Apr 5, 2018
@ldez ldez added kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. labels Apr 5, 2018
ldez
ldez approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e74e7cf into traefik:v1.6 Apr 6, 2018
@ldez ldez mentioned this pull request Apr 9, 2018
Closed
@nmengin nmengin deleted the hotfix/acme-cert-on-acme-entrypoint branch August 3, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @juliens @mmatur @ldez @traefiker