Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template version documentation. #3184

Merged
merged 1 commit into from
Apr 15, 2018
Merged

Fix template version documentation. #3184

merged 1 commit into from
Apr 15, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 13, 2018

What does this PR do?

Remove quotes around templateVersion in the documentation.

Motivation

Have a clear documentation.

More

  • Added/updated documentation

@ldez ldez requested review from a team as code owners April 13, 2018 12:46
@traefiker traefiker added this to the 1.6 milestone Apr 13, 2018
SantoDE
SantoDE approved these changes Apr 13, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

mmatur
mmatur approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 15, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

@traefiker traefiker merged commit 749d833 into traefik:v1.6 Apr 15, 2018
@ldez ldez deleted the doc/template-version branch April 16, 2018 00:28
@mmatur mmatur changed the title fix: template version documentation. Fix template version documentation. Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @SantoDE @mmatur @nmengin @traefiker