Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to override certificates in key-value store when using storeconfig #3202

Merged
merged 3 commits into from
May 17, 2018
Merged

Enable to override certificates in key-value store when using storeconfig #3202

merged 3 commits into from
May 17, 2018

Conversation

thomasjpfan
Copy link
Contributor

What does this PR do?

Adds --acme.keepcerts option to traefik. When this option is set to true, certificates already in key-value store will not be overwritten when using storeconfig.

Motivation

Closes #3003.

More

  • Added/updated tests.
  • Added/updated documentation

@emilevauge
Copy link
Member

@thomasjpfan thanks a lot for your contribution :)
We had a discussion on this topic, and we think the initial issue is a bug, we shouldn't erase existing certificates from KV store when calling storeconfig. Instead, we think we should keep existing certificates in KV store, and erase them while calling storeconfig only if providing an option --acme.overrideCertificates.
WDYT ?

@thomasjpfan
Copy link
Contributor Author

That is a great idea. I will update the PR to reflect your suggestion.

juliens
juliens approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added the kind/enhancement a new or improved feature. label May 16, 2018
@mmatur mmatur added this to the 1.7 milestone May 16, 2018
nmengin
nmengin approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this useful PR 👏 👏

LGTM

@ldez ldez changed the title ENH: Adds keepcerts feature Enable to override certificates in key-value store when using storeconfig May 17, 2018
@traefiker traefiker merged commit 4a3b1f3 into traefik:master May 17, 2018
@dtomcej dtomcej mentioned this pull request May 18, 2018
Closed
@actraiser actraiser mentioned this pull request Aug 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees

@juliens juliens

@nmengin nmengin

Labels
area/acme kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@thomasjpfan @emilevauge @juliens @mmatur @nmengin @ldez @traefiker