Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitelist and XFF. #3211

Merged
merged 5 commits into from
Apr 23, 2018
Merged

Fix whitelist and XFF. #3211

merged 5 commits into from
Apr 23, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 19, 2018 •
edited
Loading

What does this PR do?

  • Remove the limit of 1 value for XFF.
  • Enhance logs.

Motivation

Fixes #3210

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone Apr 19, 2018
juliens
juliens approved these changes Apr 19, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur changed the title fix: whitelist and XFF. Fix whitelist and XFF. Apr 23, 2018
@traefiker traefiker merged commit edb5b3d into traefik:v1.6 Apr 23, 2018
@traefiker traefiker mentioned this pull request Apr 23, 2018
Closed
@ldez ldez deleted the fix/whitelist-xff branch April 23, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker