Remove acme provider dependency in server #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
requested changes
Apr 24, 2018
server/server.go
Outdated
| @@ -79,10 +78,18 @@ type Server struct { | |||
| entryPoints map[string]EntryPoint | |||
| } | |||
|
|
|||
| // CertificateStore store for dynamic and static certificates | |||
| type CertificateStore struct { | |||
There was a problem hiding this comment.
Could you try to move this struct in types package please
ldez
added
status/3-needs-merge
bot/no-merge
and removed
status/2-needs-review
bot/no-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove acme provider dependency in server.
Motivation
Better separation of concern
More