Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for tracing with Jaeger #3227

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Apr 24, 2018

What does this PR do?

This PR fix documentation for Tracing with Jaeger. Set default port to 6831 instead of 6832

Like it is explain in Jaeger documentation, the agent accept multiple thrift protocols. And Træfik is only able to send trace over compact thrift protocol

Motivation

Have a better documentation

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e09d5cb into traefik:v1.6 Apr 24, 2018
@mmatur mmatur deleted the fix/documentation-tracing branch April 24, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants