Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance entry point TLS CLI reference. #3290

Merged
merged 1 commit into from
May 13, 2018
Merged

Enhance entry point TLS CLI reference. #3290

merged 1 commit into from
May 13, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 8, 2018 •
edited
Loading

What does this PR do?

Enhance entry point TLS CLI reference.

Motivation

Have a better documentation.

Fixes #3289

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 1.6 milestone May 8, 2018
@ldez ldez force-pushed the feature/doc-entrypoint-cli-tls branch from b05368b to 5c7a470 Compare May 8, 2018 20:29
@ldez ldez added the area/tls label May 8, 2018
@ldez ldez changed the title doc: enhance entry point TLS CLI reference. Enhance entry point TLS CLI reference. May 9, 2018
mmatur
mmatur approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez force-pushed the feature/doc-entrypoint-cli-tls branch from 5c7a470 to 27a4116 Compare May 12, 2018 23:52
nmengin
nmengin approved these changes May 13, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c5db8d9 into traefik:v1.6 May 13, 2018
@traefiker traefiker mentioned this pull request May 13, 2018
Closed
@ldez ldez deleted the feature/doc-entrypoint-cli-tls branch May 13, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/documentation area/tls kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @mmatur @nmengin @dtomcej @traefiker