Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Load-balancing method validation log. #3361

Merged
merged 1 commit into from
May 22, 2018
Merged

Enhance Load-balancing method validation log. #3361

merged 1 commit into from
May 22, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 21, 2018 •
edited
Loading

What does this PR do?

Enhance Load-balancing method validation log.

Motivation

Many people when they saw the previous log thought there was a problem:

level=debug msg="Validation of load balancer method for backend backend-foo failed: invalid load-balancing method ''. Using default method wrr."

@traefiker traefiker added this to the 1.6 milestone May 21, 2018
@ldez ldez force-pushed the refactor/lb-log-message branch from b687c02 to bab5bff Compare May 21, 2018 17:50
@ldez ldez force-pushed the refactor/lb-log-message branch from bab5bff to 1cc3820 Compare May 21, 2018 18:02
juliens
juliens approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bc26d9f into traefik:v1.6 May 22, 2018
@ldez ldez deleted the refactor/lb-log-message branch May 22, 2018 07:53
@MaxMood96 MaxMood96 mentioned this pull request Jan 1, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jan 2, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Mar 18, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/logs kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker