Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ACME account registration URI management #3398

Merged
merged 2 commits into from
May 28, 2018
Merged

Improve ACME account registration URI management #3398

merged 2 commits into from
May 28, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented May 28, 2018 •
edited
Loading

What does this PR do?

This PR allows improving the ACME registration URI management by adding an automatic update when caServer is modified.

Motivation

  • Be homogeneouse between KV store and file : the ACME URI registration is now automatically updated during migration from ACME V1 to ACME V2.
  • Update automatically the value if the acme.caServer option is updated.

Related to #3372 (comment)

Additional Notes

@traefiker traefiker added this to the 1.6 milestone May 28, 2018
ldez
ldez approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3f5772c into traefik:v1.6 May 28, 2018
@chrigl chrigl mentioned this pull request Jun 6, 2018
Closed
@nmengin nmengin deleted the hotfix/acme-registration-uri branch August 3, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme area/cluster kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @juliens @mmatur @ldez @traefiker