Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation changes #3405

Merged
merged 2 commits into from
May 30, 2018
Merged

Minor documentation changes #3405

merged 2 commits into from
May 30, 2018

Conversation

amincheloh
Copy link
Contributor

@amincheloh amincheloh commented May 29, 2018

  • Added/updated documentation

@amincheloh amincheloh requested a review from a team as a code owner May 30, 2018 01:32
@ldez ldez removed the bot/no-merge label May 30, 2018
@ldez ldez changed the base branch from master to v1.6 May 30, 2018 01:33
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels May 30, 2018
@@ -140,8 +140,7 @@ entryPoint = "https"
These are Let's Encrypt limitations as described on the [community forum](https://community.letsencrypt.org/t/support-for-ports-other-than-80-and-443/3419/72).

!!! note
Wildcard certificates can be generated only if `acme.dnsChallenge`
option is enable.
Wildcard certificates can be generated only if `acme.dnsChallenge` option is enable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wildcard certificates can only be generated if the acme.dnsChallenge option is enabled.

Otherwise, the backup file will be deleted when the container will be stopped and Træfik will not generate it again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the backup file will be permanently deleted when the container is stopped, and Træfik will not be able to generate it again.

@ldez ldez removed the bot/no-merge label May 30, 2018
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 8bca823 into traefik:v1.6 May 30, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels May 30, 2018
@ldez ldez changed the title Update acme.md Minor changes in the ACME documentation Jun 3, 2018
@ldez ldez changed the title Minor changes in the ACME documentation Minor documentation changes Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants