Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xforwarded method #3424

Merged

Conversation

erik-sjoestedt
Copy link
Contributor

@erik-sjoestedt erik-sjoestedt commented Jun 1, 2018

What does this PR do?

Added requested Method to auth server for Forward Authentication.

Motivation

Missing feature for authentication decision based on the request method. For example CORS responses can not be forwarded to API-endpoints without the ability to white list OPTIONS in the auth server. This could also be solved by #2162 but this ticket still holds merit.

More

Added implementation and test.

Additional Notes

The PR is very close cousin of #2398
There is no standard header for forwarding the HTTP Verb so I went with X-Forwarded-Method

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the 1.7 milestone Jun 13, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erik-sjoestedt many thanks for this feature.

LGTM 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants