Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes provider to support IPv6 Backends #3432

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jun 4, 2018

What does this PR do?

Adds brackets around IPv6 Backend Addresses in the Kubernetes Provider

Motivation

Fixes #3428

Additional Notes

The brackets are recommended as per https://tools.ietf.org/html/rfc5952 for portability, and required in certain cases.

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants