Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect change when service or node are in maintenance mode #3434

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Detect change when service or node are in maintenance mode #3434

merged 2 commits into from
Jun 5, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jun 5, 2018

What does this PR do?

This PR allow Træfik to watch maintenance change

Motivation

Fixes #3157

More

  • Added/updated tests

Additional notes

Thanks to @trondhindenes for testing

@mmatur mmatur added this to the 1.6 milestone Jun 5, 2018
@mmatur mmatur changed the title Fix detect change when service or node are in maintenance mode Detect change when service or node are in maintenance mode Jun 5, 2018
juliens
juliens approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit e299775 into traefik:v1.6 Jun 5, 2018
@traefiker traefiker mentioned this pull request Jun 5, 2018
Closed
@mmatur mmatur deleted the fix/consul-maintenance branch June 19, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @juliens @ldez @dtomcej @traefiker