Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing annotation documentation. #3454

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Add missing annotation documentation. #3454

merged 1 commit into from
Jun 8, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 7, 2018

What does this PR do?

Add missing annotation documentation.

Motivation

Have a good documentation.
Fixes #3453

More

  • Added/updated documentation

@ldez ldez requested a review from a team as a code owner June 7, 2018 10:17
@traefiker traefiker added this to the 1.6 milestone Jun 7, 2018
mmatur
mmatur approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit dec3f07 into traefik:v1.6 Jun 8, 2018
@traefiker traefiker mentioned this pull request Jun 8, 2018
Closed
@ldez ldez deleted the fix/k8s-wl branch June 8, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @dtomcej @traefiker