Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use net.JoinHostPort for servers URL #3484

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Use net.JoinHostPort for servers URL #3484

merged 1 commit into from
Jun 13, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 12, 2018

What does this PR do?

Use net.JoinHostPort for servers URL.

Motivation

Support IPv6

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 😄
LGTM
:shipit:

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦍

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants