Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logrus writer instead of os.Stderr #3498

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Use logrus writer instead of os.Stderr #3498

merged 2 commits into from
Jun 15, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 15, 2018 •
edited
Loading

What does this PR do?

Use logrus writer instead of os.Stderr

Motivation

To have better logs.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone Jun 15, 2018
juliens
juliens approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5b2b290 into traefik:v1.6 Jun 15, 2018
@ldez ldez deleted the fix/acme-logging branch June 15, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker