Added integration support for DataDog APM Tracing #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantono
force-pushed
the
dd-apm
branch
2 times, most recently
from
65b5c21
to
87fd2c9
Compare
ldez
added
status/1-needs-design-review
area/middleware/tracing
and removed
status/0-needs-triage
labels
|
Thanks @aantono for this PR, I will take a look ;) |
mmatur
requested changes
Jun 20, 2018
docs/configuration/tracing.md
Outdated
| # | ||
| backend = "datadog" | ||
|
|
||
| # Service name used in Zipkin backend |
There was a problem hiding this comment.
Could you replace Service name used in Zipkin backend by Service name used in DataDog backend
docs/configuration/tracing.md
Outdated
| [tracing.datadog] | ||
| # Local Agent Host Port instructs reporter to send spans to datadog-tracing-agent at this address | ||
| # | ||
| # Default: "127.0.0.1:6831" |
There was a problem hiding this comment.
Could you replace 127.0.0.1:6831 by 127.0.0.1:8126
docs/configuration/tracing.md
Outdated
| # Default: "" | ||
| # | ||
| globalTag = "foo:bar" | ||
|
|
There was a problem hiding this comment.
Could you remove this line please
|
|
||
| ddtracer "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/opentracer" | ||
| datadog "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer" | ||
| "strings" |
There was a problem hiding this comment.
Could you reorganize your import please?
|
|
||
| // Config provides configuration settings for a zipkin tracer | ||
| type Config struct { | ||
| LocalAgentHostPort string `description:"set datadog-agent's host:port that the reporter will used. Defaults to localhost:8126" export:"false"` |
There was a problem hiding this comment.
Could you please replace set by Set
| type Config struct { | ||
| LocalAgentHostPort string `description:"set datadog-agent's host:port that the reporter will used. Defaults to localhost:8126" export:"false"` | ||
| GlobalTag string `description:"Key:Value tag to be set on all the spans." export:"true"` | ||
| Debug bool `description:"Enable Zipkin debug." export:"true"` |
There was a problem hiding this comment.
Could you replace Zipkin by DataDog?
ldez
added
status/2-needs-review
and removed
contributor/waiting-for-corrections
labels
mmatur
requested changes
Jun 27, 2018
| // Name sets the name of this tracer | ||
| const Name = "datadog" | ||
|
|
||
| // Config provides configuration settings for a zipkin tracer |
There was a problem hiding this comment.
Could you change zipkin with datadog please
|
|
||
| "github.com/containous/traefik/log" | ||
| "github.com/opentracing/opentracing-go" | ||
|
|
There was a problem hiding this comment.
Could you please remove this line
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
bot/need-human-merge
and removed
bot/merge-retry-1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds integration support for DataDog APM Tracing
Motivation
Given that DataDog Tracing is OpenTracing API compliant, and Traefik already has support for DataDog monitoring, having ability to also send tracing would be beneficial