Change code block of traefik-web-ui to match file #3542
Conversation
nmengin
added
area/documentation
status/2-needs-review
bot/no-merge
and removed
status/0-needs-triage
labels
docs/user-guide/kubernetes.md
Outdated
| @@ -323,6 +323,7 @@ For more information, check out [the documentation](https://github.com/kubernete | |||
| Lets start by creating a Service and an Ingress that will expose the [Træfik Web UI](https://github.com/containous/traefik#web-ui). | |||
|
|
|||
| ```yaml | |||
| --- | |||
There was a problem hiding this comment.
Can probably remove that line from the actual yaml too
docs/user-guide/kubernetes.md
Outdated
| serviceName: traefik-web-ui | ||
| servicePort: 80 | ||
| servicePort: web |
|
I updated with those changes. It appears this document has the leading '---' on any yaml code block with multiple components. |
| targetPort: 8080 | ||
| --- | ||
| apiVersion: extensions/v1beta1 | ||
| kind: Ingress | ||
| metadata: | ||
| name: traefik-web-ui | ||
| namespace: kube-system | ||
| annotations: | ||
| kubernetes.io/ingress.class: traefik | ||
| spec: |
There was a problem hiding this comment.
The annotation makes sense to have in general. I'm thinking that we should rather add it to the YAML file than remove it from the inline spec.
@dtomcej WDYT?
There was a problem hiding this comment.
The argument is that we don't specify an ingress class to watch on any of our examples. If we keep it, we should be adding the class to our deployment/daemonset...
There was a problem hiding this comment.
Gotcha. Even if we decided to do that, it should be done by a separate PR. No reason to block this one.
traefiker
force-pushed
the
drewgwallace-patch-1
branch
from
c8ebcb5
to
e41f2f4
Compare
@dtomcej Docs still show corrections necessary against Master
https://github.com/containous/traefik/blob/master/examples/k8s/ui.yaml