Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 400 bad request on AWS ECS API #3629

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 16, 2018

What does this PR do?

This PR fix a HTTP 400 on AWS ECS API

time="2018-07-16T12:35:53Z" level=error msg="Unable to describe container instances: InvalidParameterException: instanceIds can have at most 100 items.\n\tstatus code: 400, request id: c74a8f28-88f4-11e8-bad3-0f447d092cd4"

Motivation

Fixes #3627

More

  • Added/updated tests

Additional Notes

@Dgadavin I have pushed a docker image with the fix on my docker hub account mmatur/traefik:fix-3627.
Could you try this fix please?

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ff2e2d5 into traefik:v1.7 Jul 17, 2018
@mmatur mmatur deleted the fix/aws-ecs-instanceids branch July 18, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants