Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TLS integration tests #3679

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Improve TLS integration tests #3679

merged 1 commit into from
Jul 31, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 26, 2018

What does this PR do?

This PR improve TLS integration tests

Motivation

Have more readable tests

More

  • Added/updated tests

@mmatur mmatur added this to the 1.7 milestone Jul 26, 2018
dtomcej
dtomcej approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou reviewed Jul 31, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

nmengin
nmengin approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit baf8d63 into traefik:v1.7 Jul 31, 2018
@mmatur mmatur deleted the feature/improve-tls-tests branch January 10, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou left review comments

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/consul area/provider/etcd area/tls kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@mmatur @juliens @jbdoumenjou @nmengin @dtomcej @traefiker