-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traefik prefix to k8s annotations #3682
Conversation
hi @zifeo both forms are supported😃 |
- `ingress.kubernetes.io/auth-type: "basic"` | ||
- `ingress.kubernetes.io/auth-secret: "mysecret"` | ||
- `traefik.ingress.kubernetes.io/auth-type: "basic"` | ||
- `traefik.ingress.kubernetes.io/auth-secret: "mysecret"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2819 :) FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have an inconsistent usage across the examples (can't check right now), we can use this PR to get things straight. But as @yue9944882 explained, the semantics don't change regardless of whether the prefix is attached or not.
@yue9944882 I believed so, however I was able to make it work without them in a RBAC cluster. |
@zifeo sry i didn't follow. is it related with RBAC? |
@yue9944882 Not sure, but I definitely lost 1+ hour trying to having it work. The prefix were the issue in my case. |
@zifeo Can you rebase this off of |
@dtomcej Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Documentation: fix missing traefik prefix in k8s authentification annotations.
Motivation
—
More
Additional Notes
Likely to have other occurences. I can update this PR to change all of them.
However I need to be clear which annotations requires
traefik
in front of them beforehand.