Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating oxy dependency #3700

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Updating oxy dependency #3700

merged 1 commit into from
Jul 31, 2018

Conversation

crholm
Copy link
Contributor

@crholm crholm commented Jul 31, 2018

…message codes is not forwarding through traefik

What does this PR do?

Updating oxy dependency to latest version in order to fix issue #3683

Motivation

Issue with websocket not forwarding Ping/Pong messages

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

The unit tests all pass but i cant make integration tests work since it fails before websocket portion
FAIL: https_test.go:337: HTTPSSuite.TestWithClientCertificateAuthenticationMultipeCAs

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…g/pong message codes is not forwarding through traefik
@mmatur mmatur changed the title updating oxy dependency which fixes issue #3683, Websocket ping/pong … Updating oxy dependency Jul 31, 2018
@traefiker traefiker merged commit 967e420 into traefik:v1.7 Jul 31, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Jul 31, 2018
@dduportal dduportal changed the title Updating oxy dependency Updating oxy dependency Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants