Improve Connection Limit Kubernetes Documentation #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
approved these changes
Aug 1, 2018
ldez
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
|
Perhaps we should add a note before the list of annotations to this effect ... it's useful information for debugging because its a simple typo to make whenever the value is a number .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a mistake in documentation.
Motivation
Example documentation does not have an annotation value quoted. Since annotations must be strings, this annotation just gets skipped by the kubernetes API server, as it is parsed as an integer when unquoted. Quoting the number solves the issue.
More