Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a keyType to ACME if the account is stored with no KeyType #3733

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Set a keyType to ACME if the account is stored with no KeyType #3733

merged 1 commit into from
Aug 8, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Aug 6, 2018

What does this PR do?

This PR set a KeyType to an already existent ACME.account if necessary.

Motivation

Relates #3468 (comment).

More

  • Added/updated tests

@traefiker traefiker added this to the 1.7 milestone Aug 6, 2018
dtomcej
dtomcej approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

ldez
ldez approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d04b4fa into traefik:v1.7 Aug 8, 2018
@ldez ldez mentioned this pull request Aug 25, 2018
Closed
@nmengin nmengin deleted the hotfix/fix-acme-keytype branch September 14, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @mmatur @ldez @dtomcej @traefiker