Adding warnings and solution about the configuration exposure #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
nmengin
approved these changes
Aug 20, 2018
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
juliens
requested changes
Aug 20, 2018
| @@ -38,6 +41,16 @@ For more customization, see [entry points](/configuration/entrypoints/) document | |||
|
|
|||
|  | |||
|
|
|||
| ## Security | |||
|
|
|||
There was a problem hiding this comment.
Maybe a sentence about "don't expose the api port publicly"?
There was a problem hiding this comment.
done, thanks for the idea and feedback!
…rt restriction Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This Pull Request introduces a few warnings and references in the documentation about the impact of enabling the API/Dashboard.
Motivation
Related to #3665, #3651, #3669
More