Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tiny rewording on the documentation API's page #3794

Merged
merged 1 commit into from
Aug 20, 2018
Merged

A tiny rewording on the documentation API's page #3794

merged 1 commit into from
Aug 20, 2018

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Aug 20, 2018

Signed-off-by: Damien DUPORTAL damien.duportal@gmail.com

What does this PR do?

Rewording "secret" to "sensitive data" in the documentation's APi page
for a better semantic and meaning.

Motivation

The previous word usage was scary and not conveying the right information.

More

  • Added/updated documentation

Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2beb523 into traefik:v1.6 Aug 20, 2018
@dduportal dduportal deleted the docs-rewording-api branch August 20, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants