Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment support for ECS #3817

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Aug 23, 2018

What does this PR do?

This PR add support for segment in ECS provider in favor of #3670.

Motivation

Add segment support to ECS

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Close #3670

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbdoumenjou
Copy link
Member

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants