StoreConfig always initializes the account if it is missing #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
priority/P2
ldez
added
status/2-needs-review
and removed
priority/P2
mmatur
requested changes
Aug 31, 2018
cmd/storeconfig/storeconfig.go
Outdated
| if err != nil { | ||
| return false, err | ||
| } | ||
| return len(list) > 0, nil |
There was a problem hiding this comment.
Could you please add a new line before?
nmengin
approved these changes
Aug 31, 2018
This comment has been minimized.
This comment has been minimized.
1 task
juliens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The StoreConfig command will now always initialize the account (which key path is defined by acme.storage) if it is not yet initialized.
Motivation
Related #3787 #3776
Fixes #3754