Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing quotes around backendName in kv template #3885

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Add missing quotes around backendName in kv template #3885

merged 2 commits into from
Sep 14, 2018

Conversation

NatMarchand
Copy link
Contributor

@NatMarchand NatMarchand commented Sep 13, 2018 •
edited
Loading

What does this PR do?

This PR fixes the KV template with missing quotes around $backendName.

Motivation

The generated templates are wrong and therefore backends containing dot in the name doesn't work well.
Here is an excerpt of the difference in a generated config (note the quotes for loadbalancer section whereas no quotes for healthCheck) :

[backends.\"backend.consul\".loadBalancer]
      method = \"drr\"
      sticky = false
[backends.backend.consul.healthCheck]
    path = \"/\"
    port = 0
    interval = \"10s\"

@ldez ldez changed the base branch from master to v1.7 September 13, 2018 17:53
@ldez ldez added this to the 1.7 milestone Sep 13, 2018
ldez
ldez approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR @NatMarchand 👍 👏

LGTM

@traefiker traefiker merged commit 36966da into traefik:v1.7 Sep 14, 2018
@NatMarchand
Copy link
Contributor Author

Thx for your quick approval ! It was my pleasure to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/kv kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@NatMarchand @mmatur @ldez @nmengin @traefiker