Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some DNS providers issues #3915

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Fix some DNS providers issues #3915

merged 1 commit into from
Sep 21, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 21, 2018 •
edited
Loading

What does this PR do?

  • fix ns1 getHostedZone.
  • fix gcloud, azure, iij errors.
  • fix gcloud and wilcard

Motivation

Fixes #3912, #3871

@traefiker traefiker added this to the 1.7 milestone Sep 21, 2018
@ldez ldez added the bot/light-review decreases the number of required LGTM from 3 to 1. label Sep 21, 2018
@ldez ldez changed the title Update lego Fix some DNS providers issues Sep 21, 2018
nmengin
nmengin approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 38d6556 into traefik:v1.7 Sep 21, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Sep 21, 2018
This was referenced Sep 21, 2018
Closed
Closed
@ldez ldez deleted the fix/update-lego branch September 21, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @nmengin @traefiker