Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't challenge ACME when host rule on another entry point #3923

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Don't challenge ACME when host rule on another entry point #3923

merged 1 commit into from
Sep 27, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 25, 2018

What does this PR do?

Verify that the Host in onHostRule is on the ACME EntryPoint.

Motivation

Fixes #3918

@traefiker traefiker added this to the 1.7 milestone Sep 25, 2018
ldez
ldez approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 7033b99 into traefik:v1.7 Sep 27, 2018
@traefiker traefiker mentioned this pull request Sep 27, 2018
Closed
@juliens juliens deleted the fix-acme-entrypoints branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @dduportal @ldez @dtomcej @traefiker