Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the first static certificate as a fallback when no default is given #3948

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Use the first static certificate as a fallback when no default is given #3948

merged 2 commits into from
Sep 28, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 28, 2018 •
edited by geraldcroes
Loading

What does this PR do?

When DefaultCertificate is not defined, we use the first certificate from tls.Certificates.

Motivation

Fixes #3935

@traefiker traefiker added this to the 1.7 milestone Sep 28, 2018
ldez
ldez approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliens juliens added the kind/bug/fix a bug fix label Sep 28, 2018
@geraldcroes geraldcroes changed the title Use static certs as default certificate if not defined Use the first static certificate as a fallback when no default is given Sep 28, 2018
geraldcroes
geraldcroes approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnypony3 johnypony3 mentioned this pull request Sep 28, 2018
Closed
@ldez ldez removed the bot/no-merge label Sep 28, 2018
@traefiker traefiker merged commit 8cc3c4a into traefik:v1.7 Sep 28, 2018
@juliens juliens deleted the fix-3935 branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/tls kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @geraldcroes @jbdoumenjou @ldez @traefiker