Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Template-ability check to Kubernetes API Fields #3964

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Add Template-ability check to Kubernetes API Fields #3964

merged 1 commit into from
Oct 4, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Oct 1, 2018

What does this PR do?

Adds a safety check to avoid template-unsafe values getting applied to the template directly from the k8s API

Motivation

Fixes issue #3953

More

  • Added/updated tests
  • Added/updated documentation - None needed, bugfix

@dtomcej dtomcej requested a review from a team as a code owner October 1, 2018 16:02
@traefiker traefiker added this to the 1.7 milestone Oct 1, 2018
@dtomcej dtomcej added the kind/bug/fix a bug fix label Oct 1, 2018
ldez
ldez approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 31f9200 into traefik:v1.7 Oct 4, 2018
@dtomcej dtomcej mentioned this pull request Oct 4, 2018
Closed
@dtomcej dtomcej mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@dtomcej @mmatur @ldez @nmengin @traefiker