Add the AuthResponseHeaders to the labels #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geraldcroes
added
area/authentication
contributor/waiting-for-feedback
and removed
status/0-needs-triage
labels
ldez
added
kind/enhancement
This comment has been minimized.
This comment has been minimized.
dduportal
added
resolution/declined
and removed
contributor/waiting-for-feedback
labels
|
Hi @Crypto89, good news, we've given additional thoughts to your contribution and think that it should be included in the next minor version. Good news again: we'll handle the tedious work involved in merging your contribution back into master. See you around, and keep having fun with Traefik! |
ldez
added
status/2-needs-review
and removed
resolution/declined
status/1-needs-design-review
labels
* Add the labels to the GetAuth method * Add AuthResponseHeaders to consul_catalog.tmpl * Add test for Auth.Forward to consulcatalog tests * Add documentation
ldez
added
kind/bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I've added logic to the labels.GetAuth to fill the types.Forward with the AuthResponseHeaders and updated the consul_catalog.tmpl to add the fields to the configuration.
Motivation
Currently isn't impossible to use the consul_catalog provider with auth.forward and send the authresponse headers to backends.
More
Additional Notes
I've only updated the consul_catalog backend, except kubernetes it doesn't look like any other backend will work at the moment.