Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't initialize ACME provider if storage is empty #3988

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Don't initialize ACME provider if storage is empty #3988

merged 1 commit into from
Oct 8, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Oct 8, 2018

What does this PR do?

This PR adds a test on the acme.storage option in the way to initialize ACME provider only if this option is provided.

Motivation

Have a more explicit error message.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.7 milestone Oct 8, 2018
ldez
ldez approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

mmatur
mmatur approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a777c35 into traefik:v1.7 Oct 8, 2018
@geraldcroes geraldcroes changed the title Not allow ACME provider initialization if storage is empty Don't initalize ACME provider if storage is empty Oct 15, 2018
@ldez ldez changed the title Don't initalize ACME provider if storage is empty Don't initialize ACME provider if storage is empty Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @mmatur @ldez @dtomcej @traefiker